Feat: add e2e prover #188
Merged
Feat: add e2e prover #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr is still buggy and not ready for review. Just make it to trigger CI for later commits. |
|
hero78119
reviewed
Sep 10, 2024
kunxian-xia
requested review from
hero78119,
dreamATD and
spherel
and removed request for
spherel
hero78119
approved these changes
Sep 11, 2024
| let mut zkvm_witness = ZKVMWitnesses::default(); | ||
| // assign opcode circuits | ||
| zkvm_witness | ||
| .assign_opcode_circuit::<AddInstruction<E>>(&zkvm_cs, &add_config, records) |
There was a problem hiding this comment.
(Future TODO)
Just an further refine of api , if we make instruction config implementing a trait, then we can also keep xxx_config in zkvm_cs. With that, the api can be further simplified to
zkvm_cs.register_opcode_circuit::<AddInstruction<E>>(); // no return value, config in maintained in zkvm_cs
...
zkvm_witness.assign_opcode_circuit::<AddInstruction<E>>(&zkvm_cs, records)
...
kunxian-xia
pushed a commit
that referenced
this pull request
Sep 12, 2024
…212) _Follow-up to #188 The above PR started to depend on a special internal type, originally and confusingly named `Instruction`. This PR uses the intended public type `DecodedInstruction` and makes the weird one private. Co-authored-by: Aurélien Nicolas <[email protected]>
Closed
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
…212) _Follow-up to #188 The above PR started to depend on a special internal type, originally and confusingly named `Instruction`. This PR uses the intended public type `DecodedInstruction` and makes the weird one private. Co-authored-by: Aurélien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
ZKVMProvingKey, ZKVMVerifyingKey, ZKVMConstraintSystem.ceno_emulcrate to storeInstructioninside step record.